Adding inner hits docs #7677
Merged
Adding inner hits docs #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
AntonEliatra
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
Signed-off-by: AntonEliatra <[email protected]>
hdhalter
added
3 - Tech review
5 tasks
|
@AntonEliatra Thanks for a detailed documentation. Looks great, just couple of minor comments. |
Signed-off-by: AntonEliatra <[email protected]>
rishabhmaurya
approved these changes
Aug 2, 2024
hdhalter
added
4 - Doc review
Naarcha-AWS
added
search-and-query
Signed-off-by: Anton Rubin <[email protected]>
kolchfa-aws
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Thanks so much, @AntonEliatra! Please see my comments and tag me when the PR is ready for editorial review.
|
@AntonEliatra Could you also add this and the search shard routing to the table in the index page for searching data? https://opensearch.org/docs/latest/search-plugins/searching-data/index/ |
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
natebower
requested changes
Aug 20, 2024
There was a problem hiding this comment.
@AntonEliatra @kolchfa-aws Please see my comments and changes and tag me on the comment resolutions for approval. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
|
@natebower I've pushed the update now. I left some comments on parts that I'm not entirely sure on. |
natebower
reviewed
Aug 20, 2024
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
natebower
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
@AntonEliatra @kolchfa-aws It looks like all comments/changes have been resolved, so LGTM. Thanks!
|
@AntonEliatra Please resolve merge conflicts; then we'll be ready to merge. |
Signed-off-by: AntonEliatra <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Adding documentation for inner_hits #7507 Signed-off-by: AntonEliatra <[email protected]> * Adding documentation for inner_hits #7507 Signed-off-by: AntonEliatra <[email protected]> * fixing typos in inner_hits Signed-off-by: AntonEliatra <[email protected]> * adding documenation for inner hits Signed-off-by: AntonEliatra <[email protected]> * adding documenation for inner hits Signed-off-by: AntonEliatra <[email protected]> * updating examples as per PR comments Signed-off-by: AntonEliatra <[email protected]> * updating as per review comments Signed-off-by: Anton Rubin <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * updating as per PR comments Signed-off-by: Anton Rubin <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * updating as per PR comments Signed-off-by: Anton Rubin <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Signed-off-by: Anton Rubin <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 3365b95) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Sep 12, 2024
* Adding documentation for inner_hits opensearch-project#7507 Signed-off-by: AntonEliatra <[email protected]> * Adding documentation for inner_hits opensearch-project#7507 Signed-off-by: AntonEliatra <[email protected]> * fixing typos in inner_hits Signed-off-by: AntonEliatra <[email protected]> * adding documenation for inner hits Signed-off-by: AntonEliatra <[email protected]> * adding documenation for inner hits Signed-off-by: AntonEliatra <[email protected]> * updating examples as per PR comments Signed-off-by: AntonEliatra <[email protected]> * updating as per review comments Signed-off-by: Anton Rubin <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * updating as per PR comments Signed-off-by: Anton Rubin <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * updating as per PR comments Signed-off-by: Anton Rubin <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Signed-off-by: Anton Rubin <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Eric Pugh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding inner hits documentation
Issues Resolved
Partly of 7507
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.