Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cjk bigram token filter page #7916

Merged
merged 14 commits into from
Sep 13, 2024
Merged

Add Cjk bigram token filter page #7916

merged 14 commits into from
Sep 13, 2024

Conversation

AntonEliatra
Copy link
Contributor

Description

Add Cjk bigram token filter page

Issues Resolved

Closes #7874

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@hdhalter hdhalter added 3 - Tech review PR: Tech review in progress analyzers labels Aug 6, 2024
@AntonEliatra
Update cjk-bigram.md
b410211 
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
updating the configs
995516c 
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
updating examples
47cff69 
Signed-off-by: AntonEliatra <[email protected]>
@kolchfa-aws
Copy link
Collaborator

@udabhas Could you review this PR for technical accuracy?

@vagimeli
Copy link
Contributor

@varun-lodaya The documentation is awaiting tech review and approval, which is delaying progress. Could you please suggest alternative reviewers who can assist with this task in a timely manner? We're eager to move this forward. Thank you.

@vagimeli vagimeli added the Needs SME Waiting on input from subject matter expert label Aug 29, 2024
udabhas
udabhas approved these changes Aug 30, 2024
View reviewed changes
Copy link

@udabhas udabhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc looks good to me

@vagimeli vagimeli removed 3 - Tech review PR: Tech review in progress Needs SME Waiting on input from subject matter expert labels Aug 30, 2024
@vagimeli vagimeli added the 4 - Doc review PR: Doc review in progress label Aug 30, 2024
@vagimeli
Copy link
Contributor

vagimeli commented Aug 30, 2024 •
edited
Loading

Doc looks good to me

Thank you for the review. Moving this forward. @kolchfa-aws This PR is reader for doc review at your availability. Thank you.

kolchfa-aws
kolchfa-aws reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonEliatra! Some comments/suggestions.

_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
AntonEliatra and others added 2 commits September 12, 2024 10:48
@AntonEliatra @kolchfa-aws
Apply suggestions from code review
d133af3 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
updating as per comments
e3a1b14 
Signed-off-by: Anton Rubin <[email protected]>
@AntonEliatra
Copy link
Contributor Author

@kolchfa-aws thats been updated now

@AntonEliatra
Update cjk-bigram.md
81f16ed 
Signed-off-by: AntonEliatra <[email protected]>
kolchfa-aws
kolchfa-aws approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @AntonEliatra!

natebower
natebower reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonEliatra @kolchfa-aws Please see my changes and let me know if you have any questions. Thanks!

_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
_analyzers/token-filters/cjk-bigram.md Outdated Show resolved Hide resolved
@AntonEliatra @natebower
Apply suggestions from code review
089b16b 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@kolchfa-aws
Copy link
Collaborator

@AntonEliatra Please resolve merge conflicts so we can merge. Thanks!

@AntonEliatra
Copy link
Contributor Author

@kolchfa-aws thats been resolved now, thanks

@kolchfa-aws kolchfa-aws merged commit 9f5fe32 into opensearch-project:main Sep 13, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 13, 2024
@github-actions @kolchfa-aws @natebower
Add Cjk bigram token filter page (#7916)
c6cce85 
* adding cjk bigram token filter page #7874

Signed-off-by: AntonEliatra <[email protected]>

* updating as per PR comments

Signed-off-by: AntonEliatra <[email protected]>

* updating the heading

Signed-off-by: AntonEliatra <[email protected]>

* Updating details as per comments

Signed-off-by: AntonEliatra <[email protected]>

* Update cjk-bigram.md

Signed-off-by: AntonEliatra <[email protected]>

* updating the configs

Signed-off-by: AntonEliatra <[email protected]>

* updating examples

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* updating as per comments

Signed-off-by: Anton Rubin <[email protected]>

* Update cjk-bigram.md

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 9f5fe32)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 13, 2024
Merged
@AntonEliatra AntonEliatra deleted the CJK-bigram-token-filter-page branch September 13, 2024 13:28
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
@opensearch-trigger-bot
Add Cjk bigram token filter page (#7916) (#8259)
3ad5180
noahstaveley pushed a commit to noahstaveley/documentation-website that referenced this pull request Sep 23, 2024
@AntonEliatra @kolchfa-aws
@natebower @noahstaveley
Add Cjk bigram token filter page (opensearch-project#7916)
6c65569 
* adding cjk bigram token filter page opensearch-project#7874

Signed-off-by: AntonEliatra <[email protected]>

* updating as per PR comments

Signed-off-by: AntonEliatra <[email protected]>

* updating the heading

Signed-off-by: AntonEliatra <[email protected]>

* Updating details as per comments

Signed-off-by: AntonEliatra <[email protected]>

* Update cjk-bigram.md

Signed-off-by: AntonEliatra <[email protected]>

* updating the configs

Signed-off-by: AntonEliatra <[email protected]>

* updating examples

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* updating as per comments

Signed-off-by: Anton Rubin <[email protected]>

* Update cjk-bigram.md

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Noah Staveley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@udabhas udabhas udabhas approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

Assignees

@AntonEliatra AntonEliatra

@vagimeli vagimeli

@kolchfa-aws kolchfa-aws

Labels
4 - Doc review PR: Doc review in progress analyzers backport 2.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Token filters - cjk_bigram
6 participants
@AntonEliatra @kolchfa-aws @vagimeli @udabhas @natebower @hdhalter