-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to reflect k-NN FAISS AVX512 support #8307
Conversation
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
@naveentatikonda - public documentation for AVX512 PR |
@noahstaveley Could you please resolve DCO? Also, is this for versions 2.16 and above or for the next version (2.18)? |
@akashsha1 @noahstaveley I will try to review this PR by EOD. Thanks! |
DCO is resolved. This is for version 2.18 only, I updated the PR to reflect that. Thanks for confirming |
@noahstaveley Why are we seeing so many commits included in this PR. Can you rebase this PR again ? |
Signed-off-by: Noah Staveley <[email protected]>
Signed-off-by: Noah Staveley <[email protected]>
@naveentatikonda Yes sorry about that, I rebased and removed the unrelated commits. |
Signed-off-by: Noah Staveley <[email protected]>
Signed-off-by: Noah Staveley <[email protected]>
@noahstaveley Thanks for raising this PR. @kolchfa-aws can you please review it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @noahstaveley! Some suggestions for you. Once addressed, I'll move the PR to editorial review.
Signed-off-by: Noah Staveley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noahstaveley @kolchfa-aws Please see my changes and let me know if you have any questions. Thanks!
Signed-off-by: Noah Staveley <[email protected]>
…-project#8307) * AVX512 updates Signed-off-by: Noah Staveley <[email protected]> * updatedwith correct version for AVX512 release Signed-off-by: Noah Staveley <[email protected]> * change to reflect avx512/avx2 preference order Signed-off-by: Noah Staveley <[email protected]> * change to knn-index. specified order of performance Signed-off-by: Noah Staveley <[email protected]> * Update _search-plugins/knn/knn-index.md Signed-off-by: Noah Staveley <[email protected]> * Update _search-plugins/knn/settings.md and knn-index.md Signed-off-by: Noah Staveley <[email protected]> --------- Signed-off-by: Noah Staveley <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: [email protected] <[email protected]>
…-project#8307) * AVX512 updates Signed-off-by: Noah Staveley <[email protected]> * updatedwith correct version for AVX512 release Signed-off-by: Noah Staveley <[email protected]> * change to reflect avx512/avx2 preference order Signed-off-by: Noah Staveley <[email protected]> * change to knn-index. specified order of performance Signed-off-by: Noah Staveley <[email protected]> * Update _search-plugins/knn/knn-index.md Signed-off-by: Noah Staveley <[email protected]> * Update _search-plugins/knn/settings.md and knn-index.md Signed-off-by: Noah Staveley <[email protected]> --------- Signed-off-by: Noah Staveley <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: [email protected] <[email protected]>
…-project#8307) * AVX512 updates Signed-off-by: Noah Staveley <[email protected]> * updatedwith correct version for AVX512 release Signed-off-by: Noah Staveley <[email protected]> * change to reflect avx512/avx2 preference order Signed-off-by: Noah Staveley <[email protected]> * change to knn-index. specified order of performance Signed-off-by: Noah Staveley <[email protected]> * Update _search-plugins/knn/knn-index.md Signed-off-by: Noah Staveley <[email protected]> * Update _search-plugins/knn/settings.md and knn-index.md Signed-off-by: Noah Staveley <[email protected]> --------- Signed-off-by: Noah Staveley <[email protected]> Co-authored-by: kolchfa-aws <[email protected]>
Description
This change updates the documentation to reflect AVX512 hardware accelerator support that was added to speed up vector search and indexing. The k-NN index and settings pages under k-NN search are updated in this change.
Issues Resolved
Closes #8306
Version
2.18
Related to the PR: opensearch-project/k-NN#2110
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.