-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix index name in bitmap filtering docs #9032
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Russ Cam <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the docs better, @russcam! A small suggestion to keep the requests uniform.
_query-dsl/term/terms.md
Outdated
@@ -277,7 +277,7 @@ PUT /products | |||
Next, index three documents that correspond to products: | |||
|
|||
```json | |||
PUT students/_doc/1 | |||
PUT products/_doc/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PUT products/_doc/1 | |
PUT /products/_doc/1 |
_query-dsl/term/terms.md
Outdated
@@ -286,7 +286,7 @@ PUT students/_doc/1 | |||
{% include copy-curl.html %} | |||
|
|||
```json | |||
PUT students/_doc/2 | |||
PUT products/_doc/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PUT products/_doc/2 | |
PUT /products/_doc/2 |
_query-dsl/term/terms.md
Outdated
@@ -295,7 +295,7 @@ PUT students/_doc/2 | |||
{% include copy-curl.html %} | |||
|
|||
```json | |||
PUT students/_doc/3 | |||
PUT products/_doc/3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PUT products/_doc/3 | |
PUT /products/_doc/3 |
Add forward slashes to URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kolchfa-aws <[email protected]>
@russcam Could you fix DCO so we can merge this PR? I just removed the extra lines between the code blocks and the includes. Thanks! |
Description
Fix the name of the index used in some examples so that it is consistent with the surrounding documentation.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.