Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-inclusive nonmenclature update #337

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

bowenlan-amzn
Copy link
Member

Signed-off-by: bowenlan-amzn [email protected]

Issue #, if available:
#285

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review April 19, 2022 01:21
@bowenlan-amzn bowenlan-amzn requested a review from a team April 19, 2022 01:21
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #337 (4fd0c5a) into main (21cfcea) will decrease coverage by 0.19%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main     #337      +/-   ##
============================================
- Coverage     75.54%   75.35%   -0.20%     
+ Complexity     2133     2131       -2     
============================================
  Files           260      260              
  Lines         12341    12341              
  Branches       1942     1942              
============================================
- Hits           9323     9299      -24     
- Misses         1963     1990      +27     
+ Partials       1055     1052       -3     
Impacted Files Coverage Δ
...agement/indexstatemanagement/ManagedIndexRunner.kt 46.08% <0.00%> (ø)
...t/settings/LegacyOpenDistroManagedIndexSettings.kt 98.42% <ø> (ø)
...exstatemanagement/settings/ManagedIndexSettings.kt 98.43% <ø> (ø)
...arch/indexmanagement/rollup/RollupMapperService.kt 56.00% <ø> (ø)
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 75.22% <60.00%> (-1.23%) ⬇️
...agement/transport/action/explain/ExplainRequest.kt 96.96% <100.00%> (ø)
...transport/action/explain/TransportExplainAction.kt 67.31% <100.00%> (ø)
...iledmanagedindex/RetryFailedManagedIndexRequest.kt 87.50% <100.00%> (ø)
...gedindex/TransportRetryFailedManagedIndexAction.kt 64.70% <100.00%> (ø)
...statemanagement/model/destination/CustomWebhook.kt 67.14% <0.00%> (-28.58%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cfcea...4fd0c5a. Read the comment docs.

@downsrob
Copy link
Contributor

I see that a lot of the rest apis are being deprecated which used Master, and it looks like we aren't changing any of those in this PR. opensearch-project/documentation-website#450
DB's comment here #285 (comment) made it seem like that was the highest priority. Thoughts?

@bowenlan-amzn
Copy link
Member Author

I see that a lot of the rest apis are being deprecated which used Master, and it looks like we aren't changing any of those in this PR. opensearch-project/documentation-website#450 DB's comment here #285 (comment) made it seem like that was the highest priority. Thoughts?

The master usage left in our code base is in the variable, method names from core code base. I think we will do a replacement at 3.0 directly.

Other than that, it's the master_timeout param, will do as #285 (comment)

@bowenlan-amzn bowenlan-amzn merged commit 3af62f5 into opensearch-project:main Apr 19, 2022
@bowenlan-amzn bowenlan-amzn deleted the noninclusive branch April 19, 2022 18:19
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants