-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor train index and create index from template APIs in JNI layer #1918
Open
junqiu-lei
wants to merge
2
commits into
opensearch-project:main
Choose a base branch
from
junqiu-lei:refactor-jni-train
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
added
Refactoring
Improve the design, structure, and implementation while preserving its functionality
backport 2.x
v2.17.0
labels
Aug 1, 2024
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
August 1, 2024 16:55
junqiu-lei
force-pushed
the
refactor-jni-train
branch
from
August 1, 2024 17:03
07a40e0
to
293f46d
Compare
@junqiu-lei Could you provide context around what changes you are making and why? Itll help for review |
Sure, updated in PR description. |
junqiu-lei
force-pushed
the
refactor-jni-train
branch
from
August 1, 2024 22:21
293f46d
to
5c1469a
Compare
@junqiu-lei Did ./bin/jni_test pass on your local? |
junqiu-lei
force-pushed
the
refactor-jni-train
branch
from
August 1, 2024 23:08
5c1469a
to
72243d9
Compare
Yes, here is the results:
|
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
refactor-jni-train
branch
from
August 2, 2024 00:48
72243d9
to
b5b1490
Compare
3 tasks
@junqiu-lei are there next steps on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Refactoring
Improve the design, structure, and implementation while preserving its functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up from #1784, this PR refactors
CreateIndexFromTemplate
andTrainIndex
APIs within JNI layer.Related Issues
Closes #1846
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.