Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding release notes for 2.0 GA #405

Merged

Conversation

martin-gaievski
Copy link
Member

Signed-off-by: Martin Gaievski [email protected]

Description

Add release notes for 2.1.0 rc1

Issues Resolved

#385

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski requested a review from a team May 19, 2022 18:58
@martin-gaievski martin-gaievski self-assigned this May 19, 2022
@martin-gaievski martin-gaievski added the backport 2.0 auto backport label label May 19, 2022
Shivamdhar
Shivamdhar previously approved these changes May 19, 2022
* Add Abstraction for BWC tests with a basic test ([#388](https://github.com/opensearch-project/k-NN/pull/388))
* Add restart upgrade BWC Tests ([#387](https://github.com/opensearch-project/k-NN/pull/387))

### Bug Fixes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove these headings if we don't have any PRs to add in that section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same question, my reason to leave those in the notes - it's clean indication that we do not have any changes for that category. Does it make sense?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, checked previous notes, seems that in general rule is - no change no category. Let me remove empty headings

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got your point. But, in all the previous release notes we are only adding the sections that contains PRs. Just want to make things look uniform.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I agree. Just pushed commit that corrects this, please check

* Update jacoco version to 0.8.7 to support JDK 17 ([#372](https://github.com/opensearch-project/k-NN/pull/372))
* Remove rc1 build qualifier for 2.0 GA release ([#395](https://github.com/opensearch-project/k-NN/pull/395))

### Refactoring
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #405 (77769ed) into main (293d61b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #405   +/-   ##
=========================================
  Coverage     84.01%   84.01%           
  Complexity      911      911           
=========================================
  Files           130      130           
  Lines          3879     3879           
  Branches        359      359           
=========================================
  Hits           3259     3259           
  Misses          458      458           
  Partials        162      162           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0469615...77769ed. Read the comment docs.

Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski martin-gaievski merged commit a5dd71c into opensearch-project:main May 19, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 19, 2022
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit a5dd71c)
martin-gaievski added a commit that referenced this pull request May 19, 2022
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit a5dd71c)

Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants