Skip to content

Address Review Comments

This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Jul 3, 2023 in 0s

84.94% (target 70.00%)

View this Pull Request on Codecov

84.94% (target 70.00%)

Details

Codecov Report

Merging #937 (c931a77) into feature/lucene_byte_vector (a2ee834) will decrease coverage by 0.39%.
The diff coverage is 80.15%.

❗ Current head c931a77 differs from pull request most recent head ffd2ffa. Consider uploading reports for the commit ffd2ffa to get more accurate results

@@                       Coverage Diff                        @@
##             feature/lucene_byte_vector     #937      +/-   ##
================================================================
- Coverage                         85.32%   84.94%   -0.39%     
- Complexity                         1117     1131      +14     
================================================================
  Files                               152      153       +1     
  Lines                              4519     4617      +98     
  Branches                            405      415      +10     
================================================================
+ Hits                               3856     3922      +66     
- Misses                              480      503      +23     
- Partials                            183      192       +9     
Impacted Files Coverage Δ
...opensearch/knn/index/mapper/LuceneFieldMapper.java 64.81% <53.57%> (-9.61%) ⬇️
...ain/java/org/opensearch/knn/index/VectorField.java 71.42% <66.66%> (-3.58%) ⬇️
...nsearch/knn/index/mapper/KNNVectorFieldMapper.java 83.33% <80.43%> (-0.48%) ⬇️
.../java/org/opensearch/knn/index/VectorDataType.java 96.00% <96.00%> (ø)
...n/java/org/opensearch/knn/common/KNNConstants.java 93.75% <100.00%> (+0.41%) ⬆️

... and 3 files with indirect coverage changes