Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tutorials for caching secrets for non-aws models #2637

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Zhangxunmt
Copy link
Collaborator

Description

To add caching of secrets from client side to reduce API calls to secret manger in AOS, new permissions are required in the policy attached to the IAM role to fetch credentials from secret manager.

This updates are validated using OpenAI and Cohere.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt merged commit 2058d76 into opensearch-project:main Jul 16, 2024
6 of 7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 18, 2024
b4sjoo pushed a commit that referenced this pull request Jul 18, 2024
Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit 2058d76)

Co-authored-by: Xun Zhang <[email protected]>
@b4sjoo b4sjoo added the v2.16.0 Issues targeting release v2.16.0 label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x v2.16.0 Issues targeting release v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants