[Feature/multi_tenancy] Revert inadvertent migration of deleteController to SdkClient #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
samuel-oci
as code owners
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
approved these changes
Sep 17, 2024
dhrubo-os
merged commit 66d8e2b
into
opensearch-project:feature/multi_tenancy
9 checks passed
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deleting the model controller was inadvertently migrated to the SdkClient in #2585.
This reverts those changes and updates the tests appropriately.
Related Issues
Backported from #2818
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.