Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding port changes in 2.4 to main branch (refactor model cache and thread pool) #564

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Nov 18, 2022

  • refactor model cache and thread pool

Signed-off-by: Yaliang Wu [email protected]

  • address comments

Signed-off-by: Yaliang Wu [email protected]

Signed-off-by: Yaliang Wu [email protected]
Signed-off-by: Sicheng Song [email protected]

Description

This PR is a partial forwarding of port changes in branch 2.x (commit #496) to main branch.

Issues Resolved

This PR partially resolves #553 and OpenSearch-SQL #1065

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* refactor model cache and thread pool

Signed-off-by: Yaliang Wu <[email protected]>

* address comments

Signed-off-by: Yaliang Wu <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo requested a review from a team November 18, 2022 23:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #564 (ad44455) into main (b39a737) will increase coverage by 4.57%.
The diff coverage is 59.06%.

@@             Coverage Diff              @@
##               main     #564      +/-   ##
============================================
+ Coverage     61.58%   66.16%   +4.57%     
- Complexity      709      771      +62     
============================================
  Files            85       86       +1     
  Lines          3223     3257      +34     
  Branches        294      305      +11     
============================================
+ Hits           1985     2155     +170     
+ Misses         1128      991     -137     
- Partials        110      111       +1     
Flag Coverage Δ
ml-commons 66.16% <59.06%> (+4.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/ml/action/forward/TransportForwardAction.java 18.91% <0.00%> (-0.26%) ⬇️
...earch/ml/action/load/TransportLoadModelAction.java 12.84% <0.00%> (ø)
.../ml/action/syncup/TransportSyncUpOnNodeAction.java 55.38% <0.00%> (-1.76%) ⬇️
...java/org/opensearch/ml/profile/MLModelProfile.java 53.84% <ø> (ø)
...g/opensearch/ml/profile/MLPredictRequestStats.java 56.81% <ø> (ø)
...n/java/org/opensearch/ml/model/MLModelManager.java 15.98% <18.04%> (+9.19%) ⬆️
...ch/ml/action/profile/MLProfileTransportAction.java 81.25% <66.66%> (-2.09%) ⬇️
...va/org/opensearch/ml/task/MLPredictTaskRunner.java 82.01% <75.00%> (-0.13%) ⬇️
...va/org/opensearch/ml/model/MLModelCacheHelper.java 99.09% <99.09%> (ø)
.../cluster/MLCommonsClusterManagerEventListener.java 65.62% <100.00%> (-12.50%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo merged commit 19891b1 into opensearch-project:main Nov 18, 2022
@b4sjoo b4sjoo deleted the main_dev branch November 18, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward port changes in 2.x to main branch
5 participants