Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding port changes in 2.4 to main branch (add custom model size limit) #572

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Nov 23, 2022

Signed-off-by: Xun Zhang [email protected]
Signed-off-by: Sicheng Song [email protected]

Description

This PR is a partial forwarding of port changes in branch 2.x (commit #503) to main branch.

Issues Resolved

This PR partially resolves #553 and OpenSearch-SQL #1065

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@b4sjoo b4sjoo requested a review from a team November 23, 2022 01:48
@b4sjoo b4sjoo closed this Nov 23, 2022
@b4sjoo b4sjoo deleted the main_dev1 branch November 23, 2022 04:34
@b4sjoo b4sjoo restored the main_dev1 branch November 23, 2022 04:34
@b4sjoo b4sjoo reopened this Nov 23, 2022
ylwu-amzn
ylwu-amzn previously approved these changes Nov 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #572 (6a3bffa) into main (cdd6e4a) will increase coverage by 12.11%.
The diff coverage is 83.03%.

@@              Coverage Diff              @@
##               main     #572       +/-   ##
=============================================
+ Coverage     66.47%   78.58%   +12.11%     
- Complexity      784      870       +86     
=============================================
  Files            86       86               
  Lines          3281     3269       -12     
  Branches        310      309        -1     
=============================================
+ Hits           2181     2569      +388     
+ Misses          987      559      -428     
- Partials        113      141       +28     
Flag Coverage Δ
ml-commons 78.58% <83.03%> (+12.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ml/action/load/TransportLoadModelOnNodeAction.java 64.44% <0.00%> (+45.76%) ⬆️
...n/java/org/opensearch/ml/cluster/MLSyncUpCron.java 10.41% <0.00%> (-54.17%) ⬇️
...n/java/org/opensearch/ml/model/MLModelManager.java 63.37% <60.00%> (+47.38%) ⬆️
...ain/java/org/opensearch/ml/task/MLTaskManager.java 62.82% <77.08%> (-6.45%) ⬇️
.../java/org/opensearch/ml/utils/RestActionUtils.java 79.59% <80.00%> (-1.26%) ⬇️
...earch/ml/action/load/TransportLoadModelAction.java 90.29% <89.87%> (+77.44%) ⬆️
...arch/ml/action/forward/TransportForwardAction.java 75.34% <100.00%> (+56.42%) ⬆️
...h/ml/action/models/DeleteModelTransportAction.java 90.90% <100.00%> (ø)
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 100.00% <100.00%> (ø)
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <100.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo merged commit d8aea81 into opensearch-project:main Nov 23, 2022
@b4sjoo b4sjoo deleted the main_dev1 branch November 23, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward port changes in 2.x to main branch
5 participants