Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding port changes in 2.4 to main branch (fix no permission bug when update index mapping) #614

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Dec 2, 2022

Signed-off-by: Yaliang Wu [email protected]

Signed-off-by: Yaliang Wu [email protected]
Signed-off-by: Sicheng Song [email protected]

Description

This PR is a partial forwarding of port changes in branch 2.x (commit #545) to main branch.

Issues Resolved

This PR partially resolves #553 and OpenSearch-SQL #1065

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo requested a review from a team December 2, 2022 22:30
@codecov-commenter
Copy link

Codecov Report

Merging #614 (d400044) into main (c2e0d23) will increase coverage by 0.01%.
The diff coverage is 45.71%.

@@             Coverage Diff              @@
##               main     #614      +/-   ##
============================================
+ Coverage     81.29%   81.30%   +0.01%     
  Complexity      953      953              
============================================
  Files            92       92              
  Lines          3523     3525       +2     
  Branches        323      323              
============================================
+ Hits           2864     2866       +2     
  Misses          529      529              
  Partials        130      130              
Flag Coverage Δ
ml-commons 81.30% <45.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/opensearch/ml/indices/MLIndicesHandler.java 70.00% <45.71%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo merged commit b317a4f into opensearch-project:main Dec 2, 2022
@b4sjoo b4sjoo deleted the main_dev1 branch December 2, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward port changes in 2.x to main branch
5 participants