Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding port changes in 2.4 to main branch (fix running task when reload loaded model on single node cluster) #617

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Dec 5, 2022

Signed-off-by: Yaliang Wu [email protected]

Signed-off-by: Yaliang Wu [email protected]
Signed-off-by: Sicheng Song [email protected]

Description

This PR is a partial forwarding of port changes in branch 2.x (commit #561) to main branch.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@b4sjoo b4sjoo requested a review from a team December 5, 2022 22:38
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #617 (1110301) into main (b317a4f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #617      +/-   ##
============================================
- Coverage     81.30%   81.29%   -0.01%     
+ Complexity      953      952       -1     
============================================
  Files            92       92              
  Lines          3525     3524       -1     
  Branches        323      324       +1     
============================================
- Hits           2866     2865       -1     
  Misses          529      529              
  Partials        130      130              
Flag Coverage Δ
ml-commons 81.29% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/ml/task/MLTaskManager.java 67.01% <100.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo merged commit 11100ff into opensearch-project:main Dec 5, 2022
@b4sjoo b4sjoo deleted the main_dev1 branch December 5, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants