Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] Update default setting for integ tests #106

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

jmazanec15
Copy link
Member

Description

Manual backport of #104

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Updates defaul ml commons setting
"plugins.ml_commons.only_run_on_ml_node" to false. This prevents
integration tests from failing when an ml node is not explicitly added.

Signed-off-by: John Mazanec <[email protected]>
@jmazanec15 jmazanec15 requested a review from a team January 17, 2023 22:15
@jmazanec15 jmazanec15 changed the title Update default setting for integ tests [Backport 2.5] Update default setting for integ tests Jan 17, 2023
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jmazanec15
Copy link
Member Author

@jmazanec15
Copy link
Member Author

Appear to be some issues related to Native Memory Circuit Breaker. From test case, Im seeing:

error -> Native Memory Circuit Breaker is open, please check your resources!

@ylwu-amzn
Copy link
Collaborator

Appear to be some issues related to Native Memory Circuit Breaker. From test case, Im seeing:

error -> Native Memory Circuit Breaker is open, please check your resources!

Suggest changing "plugins.ml_commons.native_memory_threshold" to 100

@jmazanec15 jmazanec15 merged commit e498cba into opensearch-project:2.5 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants