[Bug]: Library downloadBuildManifest error curl: (23) Failed writing body (0 != 4804)

[prudhvigodithi]

Description

This will ensure the the path exists (either folder or file) before writing the curl output.
With the fix

+ dirname build-manifest-opensearch.yml
+ mkdir -p .
[Pipeline] sh
+ touch build-manifest-opensearch.yml
[Pipeline] sh
+ curl -sSL --retry 5 https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.16.0/latest/linux/x64/deb/builds/opensearch/manifest.yml --output build-manifest-opensearch.yml

Issues Resolved

opensearch-project/opensearch-build#4894

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peterzhuamazon]

Probably need to update the version as well?
What about testcases?

Thanks.

[prudhvigodithi]

Probably need to update the version as well? What about testcases?

Thanks.

It can go into this 6.7.2 version Peter #467. Coming to tests I dont see any tests added for vars/downloadBuildManifest.groovy, let me double check.

[prudhvigodithi]

Updated the test files @peterzhuamazon.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (3822ade) to head (8c79a56).

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #468   +/-   ##
=========================================
  Coverage     84.26%   84.26%           
  Complexity       80       80           
=========================================
  Files           106      106           
  Lines           521      521           
  Branches         61       61           
=========================================
  Hits            439      439           
  Misses           26       26           
  Partials         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[opensearch-trigger-bot]

The backport to 6.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-6.x 6.x
# Navigate to the new working tree
pushd ../.worktrees/backport-6.x
# Create a new branch
git switch --create backport/backport-468-to-6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7ddabf2ced8ea07d2da59857ec6fc9a49c08a27f
# Push it to GitHub
git push --set-upstream origin backport/backport-468-to-6.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-6.x

Then, create a pull request where the base branch is 6.x and the compare/head branch is backport/backport-468-to-6.x.