Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debian package: improve wording in postinst script #3109

Closed
wants to merge 3 commits into from
Closed

debian package: improve wording in postinst script #3109

wants to merge 3 commits into from

Commits on Jan 17, 2023

  1. postinst: remove redundant prompt for daemon-reload 

    since a daemon reload already occurs in the postinst script, it is
redundant to prompt the user to run it again.

Signed-off-by: Mae Dartmann <[email protected]>

 Changes to be committed:
	modified:   scripts/pkg/build_templates/opensearch-dashboards/deb/debian/postinst
	modified:   scripts/pkg/build_templates/opensearch/deb/debian/postinst
    Mae Dartmann committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    3f374d4 View commit details
    Browse the repository at this point in the history

  2. postinst: remove sudo from messages 

    Adding `sudo` here is redundant, because:
- `dpkg` already needs to be running as root to install the package
- `sudo` is not always preinstalled on Debian and other tools exist
- `systemctl` can use `polkit` to prompt for a password by itself

Signed-off-by: Mae Dartmann <[email protected]>

 Changes to be committed:
	modified:   scripts/pkg/build_templates/opensearch-dashboards/deb/debian/postinst
	modified:   scripts/pkg/build_templates/opensearch/deb/debian/postinst
    Mae Dartmann committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    5132883 View commit details
    Browse the repository at this point in the history

  3. postinst: improve wording 

    add missing `the` in front of name, remove redundant `using systemd`
when already using `systemctl`

Signed-off-by: Mae Dartmann <[email protected]>

 Changes to be committed:
	modified:   scripts/pkg/build_templates/opensearch-dashboards/deb/debian/postinst
	modified:   scripts/pkg/build_templates/opensearch/deb/debian/postinst
    Mae Dartmann committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    67389a5 View commit details
    Browse the repository at this point in the history