Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle core label creation #3703

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

prudhvigodithi
Copy link
Collaborator

Description

  1. Fix the bug Unrecognized named-value: 'labelName'. Located at position 1 within expression: labelName from the PR Fix label description for newly created labels #3698.
  2. Add logic to include core repos OS and OSD for label creation automation, but exclude from version increment, This way the release labels are not missed in core repos.

Issues Resolved

#3661
Part of: #3676

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #3703 (5e10028) into main (6e9a8f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3703   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         182      182           
  Lines        5419     5419           
=======================================
  Hits         4961     4961           
  Misses        458      458           

Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi
Copy link
Collaborator Author

Wrong indentation.

Fixed it peter, thanks.

@prudhvigodithi prudhvigodithi merged commit f7cc5a6 into opensearch-project:main Jul 5, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants