[NodeJS18 Upgrade] Add new dockerfiles based on AL2023 and fix incorrectly copied yml and entrypoint #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
rishabh6788
approved these changes
Sep 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #3962 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 187 187
Lines 5673 5673
=======================================
Hits 5223 5223
Misses 450 450 |
Signed-off-by: Peter Zhu <[email protected]>
|
We are waiting for the lib changes before merging: |
71 tasks
Signed-off-by: Peter Zhu <[email protected]>
|
This also fixed a issue with docker build release images: |
peterzhuamazon
changed the title
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[NodeJS18 Upgrade] Add new dockerfiles based on AL2023 and fix incorrectly copied yml and entrypoint
Also fix an issue with the docker build on opensearch-dashboards images with default yml and entrypoint for all releases.
Issues Resolved
#1563
#3743
Also closes #3963
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.