Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIMD support for k-NN in all distributions startup scripts #4407

Closed

Conversation

peterzhuamazon
Copy link
Member

Description

Add SIMD support for k-NN in all distributions startup scripts

Issues Resolved

#4386

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <[email protected]>
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65ddd1f) 91.35% compared to head (983190a) 91.35%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4407   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         190      190           
  Lines        6197     6197           
=======================================
  Hits         5661     5661           
  Misses        536      536           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Feb 5, 2024

Signed-off-by: Peter Zhu <[email protected]>
@@ -0,0 +1,133 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These version scripts are very similar. Can one .sh call/include another? Would be nice if it wasn't a big copy paste with some small changes.

@peterzhuamazon
Copy link
Member Author

Close this as the method approach has been changed.
@naveentatikonda confirms that most of the changes and loading can happen through java code after the cluster is started.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants