Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard query-insights in 2.16 #4856

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jul 16, 2024

Description

This PR onboards query insights plugin in 2.16.

  • It bundles query-insights in 2.16 components so that opensearch 2.16 distribution will have query insights by default.
  • Add query insights in os-increment-plugin-versions and os-release-issues workflows.

Issues Resolved

related to #4826

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (aefb420) to head (f7c3307).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4856      +/-   ##
==========================================
+ Coverage   92.05%   92.31%   +0.26%     
==========================================
  Files         193      193              
  Lines        6416     6445      +29     
==========================================
+ Hits         5906     5950      +44     
+ Misses        510      495      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjcy ansjcy force-pushed the add-query-insights-in-build-manifests branch from 8dd16d7 to f7c3307 Compare July 16, 2024 23:41
@gaiksaya gaiksaya added the manifest-ci-check Run manifest ci check label Jul 16, 2024
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deshsidd
Copy link
Contributor

Hi @ansjcy

Can you please also add this repo to whitesource file. Example: https://github.com/opensearch-project/opensearch-build/pull/4852/files#diff-eb7ff2f21b9d920d4f90e5e549a7a579a2aff451e216b12386a9eece750e1291R3

Let me make the change, thanks for pointing out the example

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to remove query insights from core repo once this is merged.

Thanks.

@@ -183,3 +183,9 @@ components:
- anomaly-detection
- sql
- ml-commons
- name: query-insights
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does query insights have any dependencies on other plugins?
I assume since it used to be part of core you dont need any additional dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup no additional dependencies as of now

@deshsidd
Copy link
Contributor

Made the changes as requested by @gaiksaya. Created another PR with the new changes : #4861 Please review @gaiksaya @peterzhuamazon @prudhvigodithi

@deshsidd deshsidd closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants