-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard query-insights in 2.16 #4856
Onboard query-insights in 2.16 #4856
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4856 +/- ##
==========================================
+ Coverage 92.05% 92.31% +0.26%
==========================================
Files 193 193
Lines 6416 6445 +29
==========================================
+ Hits 5906 5950 +44
+ Misses 510 495 -15 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chenyang Ji <[email protected]>
8dd16d7
to
f7c3307
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ansjcy
Can you please also add this repo to whitesource file. Example: https://github.com/opensearch-project/opensearch-build/pull/4852/files#diff-eb7ff2f21b9d920d4f90e5e549a7a579a2aff451e216b12386a9eece750e1291R3
Let me make the change, thanks for pointing out the example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to remove query insights from core repo once this is merged.
Thanks.
@@ -183,3 +183,9 @@ components: | |||
- anomaly-detection | |||
- sql | |||
- ml-commons | |||
- name: query-insights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does query insights have any dependencies on other plugins?
I assume since it used to be part of core you dont need any additional dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup no additional dependencies as of now
Made the changes as requested by @gaiksaya. Created another PR with the new changes : #4861 Please review @gaiksaya @peterzhuamazon @prudhvigodithi |
Description
This PR onboards query insights plugin in 2.16.
Issues Resolved
related to #4826
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.