Fix test cases

Signed-off-by: Sayali Gaikawad <[email protected]>
opensearch-project · Dec 15, 2023 · 7d72e1a · 7d72e1a
1 parent 4fee943
commit 7d72e1a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/lib/infra/infra-stack.ts b/lib/infra/infra-stack.ts
@@ -374,7 +374,7 @@ export class InfraStack extends Stack {
       value: nlb.loadBalancerDnsName,
     });
 
-    if (props.enableMonitoring){
+    if (props.enableMonitoring) {
       const monitoring = new InfraStackMonitoring(this, props.dashboardsUrl);
     }
   }

diff --git a/lib/monitoring/alarms.ts b/lib/monitoring/alarms.ts
@@ -18,6 +18,7 @@ export class InfraStackMonitoring {
       openSearchProcessNotFound: Metric | MathExpression,
       openSearchDashboardsProcessNotFound?: Metric | MathExpression,
     }
+
     public readonly alarms: Alarm[] = []
 
     constructor(infraStack: InfraStack, dashboardsUrl: string) {

diff --git a/lib/os-cluster-entrypoint.ts b/lib/os-cluster-entrypoint.ts
@@ -217,8 +217,8 @@ export class OsClusterEntrypoint {
       const remoteStore = `${scope.node.tryGetContext('enableRemoteStore')}`;
       const enableRemoteStore = remoteStore === 'true';
 
-      const enableMonitoringAndAlarms = scope.node.tryGetContext('enableMonitoring');
-      const enableMonitoring = enableMonitoringAndAlarms === 'true'
+      const monitoringAndAlarms = `${scope.node.tryGetContext('enableMonitoring')}`;
+      const enableMonitoring = monitoringAndAlarms === 'true';
 
       const customRoleArn = `${scope.node.tryGetContext('customRoleArn')}`;
 

diff --git a/test/os-cluster.test.ts b/test/os-cluster.test.ts
@@ -26,6 +26,7 @@ test('Test Resources with security disabled multi-node default instance types',
       additionalOsdConfig: '{ "something.enabled": "true", "something_else.enabled": "false" }',
       // eslint-disable-next-line max-len
       customConfigFiles: '{"test/data/config.yml": "opensearch/config/opensearch-security/config.yml", "test/data/roles.yml": "opensearch/config/opensearch-security/roles.yml"}',
+      enableMonitoring: true,
     },
   });