Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ability to extend this stack #75

Closed
gaiksaya opened this issue Oct 30, 2023 · 3 comments
Closed

[FEATURE] Ability to extend this stack #75

gaiksaya opened this issue Oct 30, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Oct 30, 2023

Is your feature request related to a problem?

This project deploys 2 stacks today which are dependent on each other. If the user wants to deploy this stack as a part of another CDK code base, they should be able to. We do not have a mechanism or instructions on how to consume this set up.
One of the solution is to publish this code package to npmjs.org

What solution would you like?

Ability to extend this stack so that it can be embedded with another CDK set up if required. One of the use case is opensearch-project/opensearch-devops#129
Also all the variables passed today are passed as context variables, maybe it would be helpful to have them as properties similar to https://github.com/opensearch-project/opensearch-ci#construct-props

What alternatives have you considered?

Deploy this set up first and then run the new CDK set up separately

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@gaiksaya
Copy link
Member Author

Did some research on how to do this and also synced up with @prudhvigodithi (Thanks!).
Looks like OsClusterEntrypoint which is responsible for deploying network and infra stack cannot be extended as it is not an instance of Stack base class. Planning to move the required checks and data transformation to respective classes. I suppose the entrypoint won't be useful much after that. Let me know what you think @rishabh6788 .

@gaiksaya
Copy link
Member Author

gaiksaya commented Jan 9, 2024

@gaiksaya
Copy link
Member Author

opensearch-cluster-cdk is published to npmjs.org now: https://www.npmjs.com/package/@opensearch-project/opensearch-cluster-cdk
Users can now use the package programmatically in their typescript cdk codebase to deploy the stacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants