Move all checks and default values for network stack to NetworkStack class #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaiksaya
requested review from
peterzhuamazon,
bbarani,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
rishabh6788
reviewed
Dec 21, 2023
lib/networking/vpc-stack.ts
Outdated
| let serverAccess: IPeer; | ||
| // Properties and context variables check | ||
| let cidrRange = `${props?.cidr ?? scope.node.tryGetContext('cidr')}`; | ||
| if (cidrRange == 'undefined'){ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 80.21% 80.25% +0.04%
==========================================
Files 7 7
Lines 470 471 +1
Branches 136 141 +5
==========================================
+ Hits 377 378 +1
Misses 93 93 ☔ View full report in Codecov by Sentry. |
rishabh6788
approved these changes
Dec 21, 2023
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
force-pushed
the
move-checks
branch
from
f519507 to
96bc4ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to make the checks more compatible with props as well as context variables, moving the checks and default values to NetworkStack Class. I tested the behavior with existing stack and it showed no changes.
Also removed
maxAzsproperty as it was not being used as network stack was always called with hard coded value to3.This is the first iteration of clean up. See linked issue below for whys.
Issues Resolved
#75
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.