add respository-s3 plugin install and support to pass custom iam role #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh6788
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
gaiksaya
reviewed
Oct 25, 2023
| @@ -475,30 +482,26 @@ export class InfraStack extends Stack { | |||
| cwd: '/home/ec2-user', | |||
| ignoreErrors: false, | |||
| })); | |||
| cfnInitConfig.push(InitCommand.shellCommand('set -ex;cd opensearch;sudo -u ec2-user bin/opensearch-plugin install repository-s3 --batch', { | |||
There was a problem hiding this comment.
Hi @rishabh6788 ,
Instead of manually adding the plugin name here, can we take a list of native plugins to be installed and then install in one go?
Right now its repository-s3 and discovery-ec2. In future there might be more.
Something like:
native-plugins-to-install: repository-s3, discovery-ec2?
There was a problem hiding this comment.
That is good point. Is it okay if I take that up in future PRs?
@gaiksaya
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 78.22% 78.33% +0.10%
==========================================
Files 6 6
Lines 418 420 +2
Branches 125 125
==========================================
+ Hits 327 329 +2
Misses 91 91
|
… for instance Signed-off-by: Rishabh Singh <[email protected]>
gaiksaya
approved these changes
Oct 25, 2023
gaiksaya
reviewed
Oct 25, 2023
| | isInternal | Optional | boolean | Boolean flag to make network load balancer internal. Defaults to internet-facing e.g., `--context isInternal=true` | | ||
| | enableRemoteStore | Optional | boolean | Boolean flag to enable Remote Store feature e.g., `--context enableRemoteStore=true`. See [Enable Remote Store Feature](#enable-remote-store-feature) for more details. Defaults to false | | ||
| | storageVolumeType | Optional | string | EBS volume type for all the nodes (data, ml, cluster manager). Defaults to gp2. See `lib/opensearch-config/node-config.ts` for available options. E.g., `-c storageVolumeType=gp3`. For SSD based instance (i.e. i3 family), it is used for root volume configuration. | | ||
| | customRoleArn | Optional | string | User provided IAM role arn to be used as ec2 instance profile. `-c customRoleArn=arn:aws:iam::<AWS_ACCOUNT_ID>:role/<ROLE_NAME>` | |
There was a problem hiding this comment.
Suggested change
| | customRoleArn | Optional | string | User provided IAM role arn to be used as ec2 instance profile. `-c customRoleArn=arn:aws:iam::<AWS_ACCOUNT_ID>:role/<ROLE_NAME>` | | |
| | customRoleArn | Optional | string | User provided IAM role arn to be used as EC2 instance profile. `-c customRoleArn=arn:aws:iam::<AWS_ACCOUNT_ID>:role/<ROLE_NAME>` | |
rishabh6788
added a commit
that referenced
this pull request
Nov 1, 2023
…#71) Signed-off-by: Rishabh Singh <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-71-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 401e39e0f3661928bf24b466a935499990b118ef
# Push it to GitHub
git push --set-upstream origin backport/backport-71-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
respository-s3native plugin install. This will help users to use snapshot feature out of the box, else they need to manually install the plugin and then restart the cluster. This will not affect the existing behavior.Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.