Added suffix parameter while creating the infra stack #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navneet Verma <[email protected]>
navneet1v
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 78.60% 78.57% -0.04%
==========================================
Files 6 6
Lines 430 434 +4
Branches 129 130 +1
==========================================
+ Hits 338 341 +3
- Misses 92 93 +1
|
rishabh6788
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added suffix parameter while creating the infra stack
Issues Resolved
There is no issue as such created for this, but I was creating the stack in a shared aws account and wanted to build a separate network stack. Hence I thought to add this feature.
This is a backward compatible change, as I am adding an optional parameter to ensure that older stacks still works.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.