Add metrics for OS and OSD processes #83
Conversation
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
peterzhuamazon,
bbarani,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
Signed-off-by: Sayali Gaikawad <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 79.05% 79.24% +0.18%
==========================================
Files 6 6
Lines 444 448 +4
Branches 131 132 +1
==========================================
+ Hits 351 355 +4
Misses 93 93 ☔ View full report in Codecov by Sentry. |
|
@gaiksaya LGTM, did you deploy a stack with these changes to confirm if it is working as expected? |
Yes works as expected |
lib/infra/infra-stack.ts
Outdated
| 'cpu_usage', | ||
| 'cpu_time_system', | ||
| 'cpu_time_user', | ||
| 'read_bytes', | ||
| 'write_bytes', | ||
| 'pid_count', | ||
| ], | ||
| metrics_collection_interval: 10, | ||
| }, | ||
| ]; | ||
| if (props.dashboardsUrl !== 'undefined') { | ||
| procstatConfig.push({ | ||
| pattern: 'opensearch-dashboards', | ||
| measurement: [ | ||
| 'cpu_usage', | ||
| 'cpu_time_system', | ||
| 'cpu_time_user', | ||
| 'read_bytes', | ||
| 'write_bytes', | ||
| 'pid_count', |
There was a problem hiding this comment.
Hi @rishabh6788 ,
Not sure if we need all of these metrics. Just pid_count will suffice right?
There was a problem hiding this comment.
yeah, we don't need just the process cpu and other metrics. PID should be enough.
There was a problem hiding this comment.
Fixed it. Will only give pid_count metric now. Thanks!
Signed-off-by: Sayali Gaikawad <[email protected]>
Description
Add metrics for OS and OSD processes that later can be used to add alarms. Also modified the unit of measurement for mem and disk usage from
NONE(default) toPercenthttps://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch-Agent-Configuration-File-Details.html
Issues Resolved
Part of #74
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.