Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alarms and monitoring for infra stack #84

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

gaiksaya
Copy link
Member

Description

This change adds a bunch of alarms along with alarm dashboard and namespace for all metrics so that they can stay separate for multiple infra stacks. The resources are deployed as a part of the infrastack for easy integration rather than maintaining a new stack just for monitoring.

Issues Resolved

resolves #74

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ea6747) 79.24% compared to head (7d72e1a) 80.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   79.24%   80.08%   +0.84%     
==========================================
  Files           6        7       +1     
  Lines         448      467      +19     
  Branches      132      134       +2     
==========================================
+ Hits          355      374      +19     
  Misses         93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rishabh6788
Copy link
Collaborator

Lets keep everything related to monitors and alarms optional and in a separate stack. The default deployment should be light and quick and infra stack should only deal with everything related to running OS and OSD process.

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya
Copy link
Member Author

Lets keep everything related to monitors and alarms optional and in a separate stack. The default deployment should be light and quick and infra stack should only deal with everything related to running OS and OSD process.

Separated the classes and made the alarms optional. Trying to avoid another stack as all the resources that needs to be tracked are a part of infrastrack and would need many imports/exports to carry over to another stack.

@gaiksaya gaiksaya merged commit 5af1cf7 into opensearch-project:main Dec 18, 2023
5 checks passed
@gaiksaya gaiksaya deleted the alarms branch December 18, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add optional monitoring and alarms stack
2 participants