Addresses changes made to security demo config install tool #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
admin-cred-update
branch
from
b7c8dcb to
c275291
Compare
DarshitChanpura
commented
Dec 15, 2023
| - [Getting Help](#getting-help) | ||
| - [Code of Conduct](#code-of-conduct) | ||
| - [Security](#security) | ||
| - [License](#license) |
There was a problem hiding this comment.
this table was auto-updated by VS code to the follow the section outlines in this readme. Please let me know if this should be reverted.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 79.24% 79.37% +0.13%
==========================================
Files 6 6
Lines 448 451 +3
Branches 132 134 +2
==========================================
+ Hits 355 358 +3
Misses 93 93 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
admin-cred-update
branch
from
1bb03e7 to
4c84726
Compare
2 tasks
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
admin-cred-update
branch
from
92dd56d to
a8f3476
Compare
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
rishabh6788
reviewed
Dec 18, 2023
| @@ -86,6 +86,12 @@ export class OsClusterEntrypoint { | |||
| } | |||
| const security = securityDisabled === 'true'; | |||
|
|
|||
| // adminPassword is required if security is enabled and demo config is to be run for versions 2.12 and above | |||
| const adminPassword: String = security ? `${scope.node.tryGetContext('adminPassword')}` : ""; | |||
| if (!security && Number.parseFloat(distVersion) >= 2.12 && (adminPassword === null || adminPassword === "")) { | |||
There was a problem hiding this comment.
(adminPassword === null || adminPassword === "") could just be adminPassword === 'undefined'
|
closing this in favor of #86. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were recent changes to security demo configuration setup which now requires a custom admin Password to be setup. This PR updates the documentation and related code change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.