Refactor infra-stack and remove entrypoint file #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
peterzhuamazon,
bbarani,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 80.25% 81.83% +1.58%
==========================================
Files 7 6 -1
Lines 471 446 -25
Branches 141 167 +26
==========================================
- Hits 378 365 -13
+ Misses 93 81 -12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
commented
Dec 23, 2023
| @@ -11,7 +11,7 @@ export class RemoteStoreResources { | |||
| this.snapshotS3Bucket = new Bucket(scope, `remote-store-${scope.stackName}`, { | |||
| removalPolicy: RemovalPolicy.DESTROY, | |||
| autoDeleteObjects: true, | |||
| bucketName: `${scope.stackName}`, | |||
| bucketName: `${scope.stackName.toLowerCase()}`, | |||
There was a problem hiding this comment.
Hi @rishabh6788 ,
I saw this bug while adding test cases
Bucket name must only contain lowercase characters and the symbols, period (.) and dash (-) (offset: 0)
Bucket name must start and end with a lowercase character or number (offset: 0)
Hence changing this to lowercase. I wonder if we can remove the bucket name as each stack can track the associated bucket. Unless there is another use case that I might be unaware of
Signed-off-by: Sayali Gaikawad <[email protected]>
prudhvigodithi
approved these changes
Jan 4, 2024
|
LGTM Sayali, please check the failing codecov workflow. |
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the infraStack class to add all checks and defaults value at the class level rather than in entrypoint. The change also remove entrypoint file since all it was doing was calling both network and infraclass which can be done in app.ts.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.