Use moveToTestNotebook during notebooks-reporting integration suite #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
SuZhou-Joe
approved these changes
Apr 30, 2024
raintygao
approved these changes
Apr 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
…1250) * Use moveToTestNotebook during reporting integration suite Signed-off-by: Simeon Widdis <[email protected]> * Move refresh logic out of movetonotebook and delete old method Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit c111995)
Hailong-am
pushed a commit
that referenced
this pull request
Apr 30, 2024
…1250) (#1251) * Use moveToTestNotebook during reporting integration suite Signed-off-by: Simeon Widdis <[email protected]> * Move refresh logic out of movetonotebook and delete old method Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit c111995) Co-authored-by: Simeon Widdis <[email protected]>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…pensearch-project#1250) * Use moveToTestNotebook during reporting integration suite Signed-off-by: Simeon Widdis <[email protected]> * Move refresh logic out of movetonotebook and delete old method Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While debugging the failing tests opensearch-project/dashboards-observability#1702, it looks like the reason is that the notebook loading is flaky immediately after creation. This is due to not using the refresh logic in the
moveToTestNotebookmethod in the second test suite, it was only present in the first. After looking over the usage of this method, I decided to move the refresh logic straight tomakeTestNotebookand deletedmoveToTestNotebooksince its only use seemed to be to force this refresh.Needs backport to 2.x / 2.14.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.