Update getDetectors URL to match recent API changes #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]>
kaituo
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
|
CI failed likely due to stale Dashboards snapshot: |
|
Local run: |
CCongWang
approved these changes
Apr 30, 2024
kavilla
approved these changes
Apr 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit c4c515d)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit c4c515d)
kavilla
pushed a commit
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit c4c515d) Co-authored-by: Kaituo Li <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Apr 30, 2024
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit c4c515d) Co-authored-by: Kaituo Li <[email protected]>
kaituo
added a commit
to kaituo/anomaly-detection-dashboards-plugin
that referenced
this pull request
Apr 30, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]>
4 tasks
kaituo
added a commit
to kaituo/anomaly-detection-dashboards-plugin
that referenced
this pull request
Apr 30, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]>
kaituo
added a commit
to kaituo/anomaly-detection-dashboards-plugin
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]>
dbwiddis
pushed a commit
to opensearch-project/anomaly-detection-dashboards-plugin
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]>
opensearch-trigger-bot bot
pushed a commit
to opensearch-project/anomaly-detection-dashboards-plugin
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e509a03)
opensearch-trigger-bot bot
pushed a commit
to opensearch-project/anomaly-detection-dashboards-plugin
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e509a03)
dbwiddis
pushed a commit
to opensearch-project/anomaly-detection-dashboards-plugin
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e509a03) Co-authored-by: Kaituo Li <[email protected]>
dbwiddis
pushed a commit
to opensearch-project/anomaly-detection-dashboards-plugin
that referenced
this pull request
May 1, 2024
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e509a03) Co-authored-by: Kaituo Li <[email protected]>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…ct#1257) This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in `dashboard_spec.js` and `detector_list_spec.js` were failing because they were waiting for requests to `BASE_AD_NODE_API_PATH + '/detectors*'`, which no longer exists due to the URL update. Testing: - Successfully ran all tests in `dashboard_spec.js` and `detector_list_spec.js` to ensure that they now correctly interact with the updated URL. Signed-off-by: Kaituo Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a test failure caused by the recent update of the listing detectors URL from '/detectors' to '/detectors/_list' as implemented in server/routes/ad.ts. The change was introduced in opensearch-project/anomaly-detection-dashboards-plugin#739. Previously, the tests in
dashboard_spec.jsanddetector_list_spec.jswere failing because they were waiting for requests toBASE_AD_NODE_API_PATH + '/detectors*', which no longer exists due to the URL update.Testing:
dashboard_spec.jsanddetector_list_spec.jsto ensure that they now correctly interact with the updated URL.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.