Remove the old datasource tests for dashboards observability #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
|
Could any of the maintainers help to add the label for backport 2.x and 2.16? Thanks! |
ps48
approved these changes
Aug 1, 2024
74 tasks
RyanL1997
force-pushed
the
rm-datasource
branch
from
dcc4705
to
8ecea40
Compare
|
The PR opensearch-project/dashboards-observability#2024 fixes the failing test |
ashwin-pc
approved these changes
Aug 1, 2024
|
I guess we should migrate the test to core dashboards as the observability data sources has been moved into OSD core. Raised an issue #1478 to track. |
SuZhou-Joe
approved these changes
Aug 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit cb6de74)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit cb6de74)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit cb6de74) Co-authored-by: Jialiang Liang <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit cb6de74) Co-authored-by: Jialiang Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the old datasource tests for dashboards observability since the datasource plugin in dashboards observability has been unregistered
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.