Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select checkbox via id instead of class name #1503

Merged

Conversation

nisgoel-amazon
Copy link
Contributor

@nisgoel-amazon nisgoel-amazon commented Aug 5, 2024

Description

There is flaky test where checkbox is not getting selected in windows run.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@getsaurabh02 getsaurabh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Nishant Goel <[email protected]>
@nisgoel-amazon
Copy link
Contributor Author

Lint Checker is failing with some errors, can we please fix that: https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/10250963563/job/28357892973?pr=1503

will be fixed by #1505

@nisgoel-amazon
Copy link
Contributor Author

Index Management Release tests workflow in Bundled OpenSearch Dashboards / tests / Run Cypress E2E tests for Index Management (pull_request)
This check will be failing on main branch as security has made changes to system index opensearch-project/security#4471 which was reverted in 2.16 to fix ISM and ISM Dashboard tests
reverted pr - opensearch-project/security#4616

@prudhvigodithi prudhvigodithi merged commit 77b4d19 into opensearch-project:main Aug 5, 2024
38 of 39 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 5, 2024
* select checkbox via id instead of class name

Signed-off-by: Nishant Goel <[email protected]>

* Re trigger PR workflows

Signed-off-by: Nishant Goel <[email protected]>

* Instead of sorting in asc order on aliases page, search the alias via text

Signed-off-by: Nishant Goel <[email protected]>

---------

Signed-off-by: Nishant Goel <[email protected]>
(cherry picked from commit 77b4d19)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 5, 2024
* select checkbox via id instead of class name

Signed-off-by: Nishant Goel <[email protected]>

* Re trigger PR workflows

Signed-off-by: Nishant Goel <[email protected]>

* Instead of sorting in asc order on aliases page, search the alias via text

Signed-off-by: Nishant Goel <[email protected]>

---------

Signed-off-by: Nishant Goel <[email protected]>
(cherry picked from commit 77b4d19)
prudhvigodithi pushed a commit that referenced this pull request Aug 5, 2024
* select checkbox via id instead of class name

Signed-off-by: Nishant Goel <[email protected]>

* Re trigger PR workflows

Signed-off-by: Nishant Goel <[email protected]>

* Instead of sorting in asc order on aliases page, search the alias via text

Signed-off-by: Nishant Goel <[email protected]>

---------

Signed-off-by: Nishant Goel <[email protected]>
(cherry picked from commit 77b4d19)

Co-authored-by: Nishant Goel <[email protected]>
prudhvigodithi pushed a commit that referenced this pull request Aug 5, 2024
* select checkbox via id instead of class name

Signed-off-by: Nishant Goel <[email protected]>

* Re trigger PR workflows

Signed-off-by: Nishant Goel <[email protected]>

* Instead of sorting in asc order on aliases page, search the alias via text

Signed-off-by: Nishant Goel <[email protected]>

---------

Signed-off-by: Nishant Goel <[email protected]>
(cherry picked from commit 77b4d19)

Co-authored-by: Nishant Goel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants