Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly playground #136

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jan 23, 2024

Description

This change adds the initial draft of nightly playgrounds with below specifics:

  1. distribution version, distribution urls are grabbed on the go whereas all other important parameters are hardcoded in the code
  2. Adds tests
  3. Adds GHA workflow to run tests

Issues Resolved

#129

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 23, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya force-pushed the add-nightly-playground branch from c04d563 to 7f7ffe4 Compare January 23, 2024 23:36
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So from the looks of it, this is basically import cluster cdk, and deploy a stack of OpenSearch / Dashboards with provided url?

Just wondering why cant we use the existing cluster cdk directly?

Thanks.

Comment on lines 4 to 6
push:
paths:
- nightly-playground/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think pr trigger is enough here.

@gaiksaya
Copy link
Member Author

So from the looks of it, this is basically import cluster cdk, and deploy a stack of OpenSearch / Dashboards with provided url?

Just wondering why cant we use the existing cluster cdk directly?

Thanks.

The reason we went with this approach is to reduce the context variables and source code what is required for this use case. Such as security should always be enabled. Also, for future stacks, we can extend / depend on this base stacks. Another reason was to stick to 1 version of opensearch-cluster-cdk. The project is pretty new and has active changes coming in more often which we need not be bothered unless required.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaiksaya confirms that mend error is not related.
Approved now, thanks.

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya merged commit ebb2ca8 into opensearch-project:main Jan 24, 2024
6 checks passed
@gaiksaya gaiksaya deleted the add-nightly-playground branch January 24, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants