Enable snapshot repo registration and fix cdk_vars #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon and
prudhvigodithi
as code owners
gaiksaya
commented
Apr 19, 2024
Comment on lines
+151
to
+157
| # - name: Restore altering configs | ||
| # run: | | ||
| # curl -XPOST "https://${{needs.validate-and-deploy.outputs.ENDPOINT}}:8443/_snapshot/snapshots-repo/<replace_with_snapshot_id>/_restore" -H 'Content-Type: application/json' -d' | ||
| # { | ||
| # "indices": ".opendistro-alerting-config,.opensearch-notifications-config", | ||
| # "ignore_unavailable": false, | ||
| # }' -u ${{ secrets.OPENSEARCH_USER }}:${{ secrets.OPENSEARCH_PASSWORD }} --insecure |
There was a problem hiding this comment.
To be enabled after snapshot registration is successful and we have a snapshot to register that contains the mentioned indices
peterzhuamazon
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an additional job in the workflow to register a snapshot repository within the cluster with
versionXas base path.Also fixes the cdk_vars typo due to which the GH output was not being set
Adds
-fflag to the curl command to fail fastIssues Resolved
#132
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.