Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set httpcore5 to 5.2 to be compatible with httpclient5 5.2.1 #566

Closed
wants to merge 1 commit into from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 6, 2023

Description

org.apache.httpcomponents.client5:httpclient5:5.2.1 is compatible with httpcore5:5.2 and the recent upgrade to 5.2.2 is causing problems running an extension using the SDK. I am opening a PR to downgrade the version to 5.2 which is compatible with httpclient:5.2.1

Issues Resolved

opensearch-project/opensearch-sdk-java#857

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reta
Copy link
Collaborator

reta commented Jul 6, 2023

@cwperks the core and opensearch-java are using the same HttpClient5 / HttpCore5 version, we need to look at SDK repo and find out where 5.2 is coming from:

Execution failed for task ':compileJava'.
> Could not resolve all dependencies for configuration ':compileClasspath'.
   > Conflict(s) found for the following module(s):
       - org.apache.httpcomponents.client5:httpclient5 between versions 5.2.1 and 5.1.4
       - org.apache.httpcomponents.core5:httpcore5 between versions 5.2.2, 5.1.5 and 5.2
       - org.apache.httpcomponents.core5:httpcore5-h2 between versions 5.2.2, 5.1.5 and 5.2

@cwperks
Copy link
Member Author

cwperks commented Jul 6, 2023

@reta the Pom file for HttpClient5:5.2.1 references HttpCore5:5.2

@reta
Copy link
Collaborator

reta commented Jul 6, 2023

@reta the Pom file for HttpClient5:5.2.1 references HttpCore5:5.2

This is fine, since we providing the version explicitly for core5, the 5.2 would have sneaked if transient only

@cwperks cwperks closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants