Linting improvements #1000
Merged
Linting improvements #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Schohn <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
============================================
+ Coverage 80.16% 80.30% +0.13%
- Complexity 2720 2722 +2
============================================
Files 370 365 -5
Lines 13624 13595 -29
Branches 938 939 +1
============================================
- Hits 10922 10917 -5
+ Misses 2131 2105 -26
- Partials 571 573 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gregschohn
force-pushed
the
LintingImprovements
branch
2 times, most recently
from
2c7b618
to
e8549eb
Compare
Signed-off-by: Greg Schohn <[email protected]>
gregschohn
force-pushed
the
LintingImprovements
branch
from
e8549eb
to
3600c60
Compare
AndreKurait
reviewed
Sep 24, 2024
| @@ -462,7 +451,7 @@ public String getFailureMessage() { | |||
| } | |||
|
|
|||
| public static class OperationFailed extends RfsException { | |||
| public final HttpResponse response; | |||
| public final transient HttpResponse response; | |||
There was a problem hiding this comment.
Interesting... i've never seen transient
Signed-off-by: Greg Schohn <[email protected]>
gregschohn
requested review from
chelma,
lewijacn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
Signed-off-by: Greg Schohn <[email protected]> # Conflicts: # RFS/src/main/java/org/opensearch/migrations/bulkload/common/InvalidResponse.java
gregschohn
force-pushed
the
LintingImprovements
branch
from
6ed1e5a
to
98e6d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.