Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata migrate get version #1003

Merged

Conversation

AndreKurait
Copy link
Member

Description

Fix double trailing slash in getClusterVersion since rest client was adding "/" which was causing 400 Bad Request in AWS against OS 2.15 (Note, was not causing issues in containers or other versions)

Bug Introduced in #922

  • Category: Bug Fix
  • Why these changes are required? AWS Opensearch Service Support
  • What is the old behavior before changes and new behavior after changes? Any Metadata Migrations to AWS Opensearch Service failed for this getVersionCall since Metadata Migration with user centric output #922

Issues Resolved

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Testing in AWS and unit tests added

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait
Copy link
Member Author

Recreating #1001 as codecov was failing

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (6c32e29) to head (494958c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1003      +/-   ##
============================================
- Coverage     80.17%   80.16%   -0.01%     
+ Complexity     2721     2720       -1     
============================================
  Files           370      370              
  Lines         13622    13622              
  Branches        938      938              
============================================
- Hits          10921    10920       -1     
- Misses         2130     2131       +1     
  Partials        571      571              
Flag Coverage Δ
gradle-test 78.17% <100.00%> (-0.01%) ⬇️
python-test 89.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chelma chelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (again)

@AndreKurait AndreKurait merged commit 7159aea into opensearch-project:main Sep 24, 2024
23 of 24 checks passed
@AndreKurait AndreKurait deleted the FixMetadataMigrateGetVersion branch September 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants