Make cdk.context.json valid json #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikayla Thompson <[email protected]>
mikaylathompson
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
peternied and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=========================================
Coverage 80.20% 80.20%
Complexity 2722 2722
=========================================
Files 365 365
Lines 13603 13603
Branches 941 941
=========================================
Hits 10910 10910
Misses 2118 2118
Partials 575 575
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mikayla Thompson <[email protected]>
peternied
added a commit
to peternied/opensearch-migrations
that referenced
this pull request
Oct 3, 2024
This ensures that our json files are valid and follow common formatting conventions. Following up to opensearch-project#1022 Signed-off-by: Peter Nied <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My last PR, #1021, broke the build. Having a not-quite-json
cdk.context.jsonwas bad anytime acdkcommand was used, even if it specifically specified a different context file.So first, I just made it valid (if kind of ugly) JSON, but that broke the build in a different way because removing a lot of the default values changed the behavior of the cdk deployments in the CI pipelines. I copied the old values from the defaults into these blocks and have tested redeploying, successfully now.
Issues Resolved
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.