Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index configuration tool] Add support for insecure HTTPS endpoint #218

Merged
merged 3 commits into from
Jun 28, 2023
Merged

[Index configuration tool] Add support for insecure HTTPS endpoint #218

merged 3 commits into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. [Index configuration tool] Add support for insecure HTTPS endpoint 

    This commit adds support for parsing the "insecure" flag from the Data Prepper YAML. This translates to a "verify" flag that is passed to the Python requests library. This commit also includes unit tests for this logic.

Signed-off-by: Kartik Ganesh <[email protected]>
    @kartg
    kartg committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    cbbe6e5 View commit details
    Browse the repository at this point in the history

  2. Better error messages in pipeline config validation 

    Separated the error messages for source and sink validation. Also fixed the unit test for this.

Signed-off-by: Kartik Ganesh <[email protected]>
    @kartg
    kartg committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b392d4a View commit details
    Browse the repository at this point in the history

  3. Incorporated PR comments 

    Fixed unnecessary bool() cast

Signed-off-by: Kartik Ganesh <[email protected]>
    @kartg
    kartg committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    cc3f56e View commit details
    Browse the repository at this point in the history