Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations - Capture and replay v0.1.0 - Extracted Comparator and Jupyter #271

Conversation

sumobrian
Copy link
Collaborator

@sumobrian sumobrian commented Aug 18, 2023

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest (Disabled unstable test)
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…v0.1.0' of github.com:opensearch-project/opensearch-migrations into capture-and-replay-v0.1.0

Signed-off-by: Brian Presley <[email protected]>
…search-migrations into capture-and-replay-v0.1.0
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #271 (f60b0c4) into capture-and-replay-v0.1.0 (72b5835) will decrease coverage by 2.38%.
Report is 1 commits behind head on capture-and-replay-v0.1.0.
The diff coverage is n/a.

@@                       Coverage Diff                       @@
##             capture-and-replay-v0.1.0     #271      +/-   ##
===============================================================
- Coverage                        61.41%   59.04%   -2.38%     
+ Complexity                         593      584       -9     
===============================================================
  Files                               74       74              
  Lines                             2991     2991              
  Branches                           279      279              
===============================================================
- Hits                              1837     1766      -71     
- Misses                             986     1057      +71     
  Partials                           168      168              
Flag Coverage Δ
unittests 59.04% <ø> (-2.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...atahandlers/http/HttpJsonTransformingConsumer.java 75.38% <ø> (ø)

... and 1 file with indirect coverage changes

@lewijacn
Copy link
Collaborator

You can also remove the kafka-broker and kafka-zookeeper copilot directories as those aren't in use since we are using MSK and didn't integrate yet

Copy link
Collaborator

@mikaylathompson mikaylathompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note about whether this will make our logs messier, but we'll figure that out quickly enough after running it and can remedy quickly.

test/tests.py Show resolved Hide resolved
Copy link
Collaborator

@mikaylathompson mikaylathompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving--despite the broken tests--to streamline getting this merged into the release branch (but we should fix the broken tests)

Signed-off-by: Brian Presley <[email protected]>
@sumobrian sumobrian merged commit 3d2e3bd into opensearch-project:capture-and-replay-v0.1.0 Aug 21, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants