On board 1-click release for OpenSearch Migrations #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
============================================
- Coverage 71.81% 65.94% -5.88%
+ Complexity 845 842 -3
============================================
Files 120 95 -25
Lines 5078 3923 -1155
Branches 452 330 -122
============================================
- Hits 3647 2587 -1060
+ Misses 1209 1129 -80
+ Partials 222 207 -15
Flags with carried forward coverage won't be shown. Click here to find out more. |
gaiksaya
reviewed
Sep 29, 2023
| with: | ||
| draft: true | ||
| generate_release_notes: true | ||
| files: artifacts.tar.gz |
There was a problem hiding this comment.
We need to first create this tar.gz before uploading. Can you please try out this workflow in your fork?
Thanks!
There was a problem hiding this comment.
Sure Sayali, will test it.
There was a problem hiding this comment.
Hey @gaiksaya with the workflow I have able to create a draft release upon a tag (0.3.0) push.
prudhvigodithi
force-pushed
the
main
branch
5 times, most recently
from
0211b50
to
7cbd92b
Compare
prudhvigodithi
requested review from
chelma,
gregschohn,
kartg,
lewijacn,
mikaylathompson,
okhasawn and
sumobrian
as code owners
gaiksaya
approved these changes
Oct 4, 2023
jenkins/release.jenkinsFile
Outdated
| ])) | ||
|
|
||
| standardReleasePipelineWithGenericTrigger( | ||
| overrideDockerImage: 'opensearchstaging/ci-runner:release-centos7-clients-v4', |
There was a problem hiding this comment.
No need to override, the 5.9.1 version has this by default: https://github.com/opensearch-project/opensearch-build-libraries/blob/5.9.1/vars/standardReleasePipelineWithGenericTrigger.groovy#L31
|
Need one maintainers approval @chelma @gregschohn @kartg @lewijacn @mikaylathompson @okhasawn @sumobrian please check. Thanks |
gaiksaya
reviewed
Oct 4, 2023
README.md
Outdated
|
|
||
| 1. Create a tag, e.g. 0.1.0, and push it to this GitHub repository. | ||
| 2. The [release-drafter.yml](.github/workflows/release-drafter.yml) will be automatically kicked off and a draft release will be created. | ||
| 3. This draft release triggers the [jenkins release workflow](https://build.ci.opensearch.org/job/opensearch-migrations-release) as a result of which the opensearch-migrations toolset is released and published on artifacts (https://artifacts.opensearch.org/migrations/0.1.0/opensearch-migrations-0.1.0.tar.gz). |
There was a problem hiding this comment.
Suggested change
| 3. This draft release triggers the [jenkins release workflow](https://build.ci.opensearch.org/job/opensearch-migrations-release) as a result of which the opensearch-migrations toolset is released and published on artifacts (https://artifacts.opensearch.org/migrations/0.1.0/opensearch-migrations-0.1.0.tar.gz). | |
| 3. This draft release triggers the [jenkins release workflow](https://build.ci.opensearch.org/job/opensearch-migrations-release) as a result of which the opensearch-migrations toolset is released and published on artifacts.opensearch.org (https://artifacts.opensearch.org/migrations/0.1.0/opensearch-migrations-0.1.0.tar.gz). |
Signed-off-by: Prudhvi Godithi <[email protected]>
sumobrian
approved these changes
Oct 4, 2023
gregschohn
added a commit
to gregschohn/opensearch-migrations
that referenced
this pull request
Oct 6, 2023
* main: On board 1-click release for OpenSearch Migrations (opensearch-project#334) Add support for Kafka management scripts (opensearch-project#330) Bump urllib3 from 2.0.3 to 2.0.6 in /test Removing extra character + moving project specific requirement back to where it belongs Update CDK documentation + minor changes to devDeploy script Signed-off-by: Greg Schohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On board 1-click release for OpenSearch Migrations
Issues Resolved
Part of: opensearch-project/opensearch-build#4085
Is this a backport? If so, please add backport PR # and/or commits #