-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing steps to DEVELOPER_GUIDE.md #194
Merged
dblock
merged 4 commits into
opensearch-project:main
from
AbhinavGarg90:updates-to-devguide
Dec 5, 2023
Merged
Adding missing steps to DEVELOPER_GUIDE.md #194
dblock
merged 4 commits into
opensearch-project:main
from
AbhinavGarg90:updates-to-devguide
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhinavGarg90
requested review from
dblock,
Xtansia,
VachaShah and
reta
as code owners
October 17, 2023 23:00
Signed-off-by: Abhinav Garg <[email protected]>
AbhinavGarg90
force-pushed
the
updates-to-devguide
branch
from
October 17, 2023 23:02
1cc45f4
to
e6c14c8
Compare
AbhinavGarg90
changed the title
initial proposal of change
Adding missing steps to DEVELOPER_GUIDE.md
Oct 17, 2023
Signed-off-by: Abhinav Garg <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 74.00% 74.00%
=======================================
Files 403 403
Lines 64198 64198
=======================================
Hits 47508 47508
Misses 16690 16690
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reta
reviewed
Oct 17, 2023
dblock
reviewed
Oct 23, 2023
@AbhinavGarg90 want to finish this? |
Signed-off-by: Abhinav Garg <[email protected]>
Signed-off-by: Abhinav Garg <[email protected]>
dblock
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds neccessary information to DEVELOPER_GUIDE.md to intialize the project on a clean install.
Issues Resolved
#184
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.