Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing steps to DEVELOPER_GUIDE.md #194

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

AbhinavGarg90
Copy link
Contributor

Description

Adds neccessary information to DEVELOPER_GUIDE.md to intialize the project on a clean install.

Issues Resolved

#184

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Abhinav Garg <[email protected]>
@AbhinavGarg90 AbhinavGarg90 changed the title initial proposal of change Adding missing steps to DEVELOPER_GUIDE.md Oct 17, 2023
Signed-off-by: Abhinav Garg <[email protected]>
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7548c9f) 74.00% compared to head (c8a5434) 74.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   74.00%   74.00%           
=======================================
  Files         403      403           
  Lines       64198    64198           
=======================================
  Hits        47508    47508           
  Misses      16690    16690           
Flag Coverage Δ
integration 74.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
DEVELOPER_GUIDE.md Show resolved Hide resolved
@dblock
Copy link
Member

dblock commented Dec 4, 2023

@AbhinavGarg90 want to finish this?

@dblock dblock merged commit 1cd13c3 into opensearch-project:main Dec 5, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants