Breaking changes for 2.0 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
| @@ -0,0 +1,60 @@ | |||
| name: Integration with Unreleased OpenSearch | |||
There was a problem hiding this comment.
May be add the workflow in a different PR?
There was a problem hiding this comment.
I added it in the same PR since the breaking changes need to be tested. WDYT? I can add the workflow in a separate PR and include only 1.x branch on it, then in this PR I can add the 2.x, 2.0 and main branch testing.
There was a problem hiding this comment.
Haha its ok.
Its easier to split pieces when they are independent, we can do it next time :)
dblock
previously approved these changes
Apr 27, 2022
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| opensearch_ref: ['1.x', '2.x', '2.0', 'main'] |
There was a problem hiding this comment.
Nit: put these on separate lines so diffs are easier when adding/removing versions
Signed-off-by: Vacha Shah <[email protected]>
saratvemulapalli
approved these changes
Apr 27, 2022
dblock
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the breaking changes that come with OpenSearch 2.0. Changes in this PR include:
Issues Resolved
Closes #57
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.