CDK (Cloud Development Kit) to create infra for project website search #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abbas Hussain <[email protected]>
abbashus
requested review from
AMoo-Miki,
CEHENKLE,
kartg,
saratvemulapalli,
setiah and
tlfeng
abbashus
changed the title
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
abbashus
commented
Sep 21, 2021
| @@ -0,0 +1,13 @@ | |||
| @echo off | |||
There was a problem hiding this comment.
This file is auto-generated as part cdk init
Signed-off-by: Abbas Hussain <[email protected]>
There was a problem hiding this comment.
While we take a look at this PR, couple of questions:
- Is there a place where have published the design in the open?
- Follow up on the above, this helps iron out design details, help understand the reviewers exactly what we are trying to achieve using CDK (this PR).
- Why is this repository in private? Can we make it public and start iterating on things?
|
Update: Found the RFC: opensearch-project/OpenSearch#1219 |
Needs Amazon Appsec approval to make this public. Work in progress. |
|
Closing this PR as this does not reflect new commits after making fork repo public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abbas Hussain [email protected]
Description
Initial CDK for creating AWS resources for project website search as defined in RFC. This is not the final code and may require further iterations.
Issues Resolved
#13
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.