CDK (Cloud Development Kit) to create infra for project website search #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
abbashus
requested review from
adnapibar,
AMoo-Miki,
kartg,
saratvemulapalli and
tlfeng
owaiskazi19
reviewed
Oct 11, 2021
|
|
||
| cluster_stack_name = app.node.try_get_context("cluster_stack_name") | ||
| network_stack_name = app.node.try_get_context("network_stack_name") | ||
| search_access_stack_name = app.node.try_get_context("search_access_stack_name") |
There was a problem hiding this comment.
Raise error for search_access_stack_name as well if not present
owaiskazi19
reviewed
Oct 11, 2021
| cluster_stack_name = app.node.try_get_context("cluster_stack_name") | ||
| network_stack_name = app.node.try_get_context("network_stack_name") | ||
| search_access_stack_name = app.node.try_get_context("search_access_stack_name") | ||
| monitoring_stack_name = app.node.try_get_context("monitoring_stack_name") |
owaiskazi19
reviewed
Oct 11, 2021
cdk/opensearch-website-search/lambdas/monitoring-lambda/monitor.py
Outdated
Show resolved
Hide resolved
owaiskazi19
reviewed
Oct 11, 2021
cdk/opensearch-website-search/lambdas/monitoring-lambda/monitor.py
Outdated
Show resolved
Hide resolved
owaiskazi19
reviewed
Oct 11, 2021
cdk/opensearch-website-search/lambdas/monitoring-lambda/monitor.py
Outdated
Show resolved
Hide resolved
owaiskazi19
reviewed
Oct 11, 2021
| health = res.json() | ||
|
|
||
| # check master available metric | ||
| if "discovered_master" in health and health["discovered_master"]: |
There was a problem hiding this comment.
Can we pull this in a separate method for this check and the rest below?
owaiskazi19
reviewed
Oct 11, 2021
|
|
||
| def __init__(self, scope: cdk.Construct, construct_id: str, vpc, nlb, opensearch_listener, **kwargs) -> None: | ||
| super().__init__(scope, construct_id, **kwargs) | ||
|
|
There was a problem hiding this comment.
Instead of making __init__ bulky. Let's have this file with methods
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
Signed-off-by: Abbas Hussain <[email protected]>
|
closing this as superseded by a draft PR: #54 which includes CDK2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial CDK for creating AWS resources for project website search as defined in RFC. This is not the final code and may require further iterations.
RFC : opensearch-project/OpenSearch#1219
Issues Resolved
#13
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.