Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoding check workflow to ensure all the files having utf-8 encoding and vale continue-on-error #2700

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Add encoding check workflow to ensure all the files having utf-8 encoding and vale continue-on-error #2700

merged 4 commits into from
Apr 2, 2024

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Apr 2, 2024 •
edited
Loading

Description

Add encoding check workflow to ensure all the files having utf-8 encoding and vale continue-on-error

Issues Resolved

Closes #2699
opensearch-project/documentation-website#6722

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@peterzhuamazon peterzhuamazon added enhancement New feature or request workflows labels Apr 2, 2024
@peterzhuamazon peterzhuamazon self-assigned this Apr 2, 2024
@peterzhuamazon
Remove test file
84351bc 
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon
Copy link
Member Author

Runs:

Failure example: https://github.com/opensearch-project/project-website/actions/runs/8527917727/job/23360384331
Success example: https://github.com/opensearch-project/project-website/actions/runs/8527980091/job/23360597158?pr=2700

@peterzhuamazon
Remove test file
2836fb9 
Signed-off-by: Peter Zhu <[email protected]>
kolchfa-aws
kolchfa-aws previously approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterzhuamazon peterzhuamazon changed the title Add encoding check workflow to ensure all the files having utf-8 encoding Add encoding check workflow to ensure all the files having utf-8 encoding and value continue-on-error Apr 2, 2024
@kolchfa-aws kolchfa-aws merged commit 8fc3b67 into opensearch-project:main Apr 2, 2024
5 checks passed
@peterzhuamazon peterzhuamazon deleted the Add-utf8-checker branch April 2, 2024 19:37
@peterzhuamazon peterzhuamazon changed the title Add encoding check workflow to ensure all the files having utf-8 encoding and value continue-on-error Add encoding check workflow to ensure all the files having utf-8 encoding and vale continue-on-error Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@elfisher elfisher Awaiting requested review from elfisher elfisher is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@krisfreedain krisfreedain Awaiting requested review from krisfreedain krisfreedain is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@nateynateynate nateynateynate Awaiting requested review from nateynateynate nateynateynate is a code owner

Assignees

@peterzhuamazon peterzhuamazon

Labels
enhancement New feature or request workflows
Projects
OpenSearch Engineering Effectiveness
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Ensure non-binary files are using utf-8 encoding
2 participants
@peterzhuamazon @kolchfa-aws