Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog url as part of subtext of roadmap #3366

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Oct 4, 2024

Description

Add blog url as part of subtext of roadmap

Screenshot 2024-10-04 at 7 07 12 PM

Specifically arrange this way so it wont be blocked by the picture on the right.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@peterzhuamazon
Copy link
Member Author

This is a follow up to #3362, please let me know if there is better way of doing this.

cc: @kaimmej

Thanks!

@kaimmej
Copy link
Contributor

kaimmej commented Oct 4, 2024

@peterzhuamazon

I think this is the best way to proceed.
I like the way that you encoded the anchor-tag into the datafile. I had not thought of doing that before.

Question
By 'picture to the right' - do you mean the Triangle that is at the bottom right corner of the documentation dropdown?
Looks great on my end. It doesnt seem to interact with the triangle, and when I view it at different display-widths, I don't see any issues.

image

@peterzhuamazon
Copy link
Member Author

Hi @kaimmej .

The transparent part of the image covers part of the subtext.
Screenshot 2024-10-04 at 9 33 16 PM

I initially try to add the 2024-2025 substring with the anchor tag but my mouse cant click on it, due to that picture covers the anchor tag.

@kaimmej kaimmej mentioned this pull request Oct 7, 2024
1 task
@kaimmej
Copy link
Contributor

kaimmej commented Oct 7, 2024

I tried to push my change to this PR but was unable to.

This is a z-index issue. We need to apply a lower z-index to the bottom right triangle, and a higher zindex to the content of the dropdown. This will bring the content of the dropdown forward and the link behavior should start working correctly.

I made a PR for this change #3367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants