-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors #1009
Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors #1009
Conversation
…IndexDescriptors Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
src/main/kotlin/org/opensearch/reportsscheduler/ReportsSchedulerPlugin.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Craig Perkins <[email protected]>
@derek-ho I pushed a commit to upgrade the baseVersion in this PR to fix the CI checks |
@cwperks with the new base version bump I think the backport will fail/need further commits to revert, but I am fine as is. |
@joshuali925 @Swiddis can we get this approved/merged? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/reporting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/reporting/backport-2.x
# Create a new branch
git switch --create backport/backport-1009-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2f8177314e61ffca0e335a428c3c689aa6fbb2bb
# Push it to GitHub
git push --set-upstream origin backport/backport-1009-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/reporting/backport-2.x Then, create a pull request where the |
…IndexDescriptors (opensearch-project#1009) (cherry picked from commit 2f81773)
Description
This PR registers the system indices in this plugin through the SystemIndexPlugin extension point in core. These indices will not be functionally different than they are today, its just a formal registration as a system index.
Issues Resolved
Related to: opensearch-project/security#4439
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.